Fix missing propagation of RoPE scaling and interpolation arguments in model builders - #2902
Closed
taehwakkwon wants to merge 2 commits into
Closed
Fix missing propagation of RoPE scaling and interpolation arguments in model builders#2902taehwakkwon wants to merge 2 commits into
taehwakkwon wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR ensures that
seq_len_interpolation_factorandrope_scaling_factorarguments are correctly propagated from the arguments to the model builder functions.Previously, even if the user specified
--seq-len-interpolation-factoror--rope-scaling-factor, these values were not being passed to the underlying model initialization logic.Changes:
gpt_builders.py): Added propagation for bothrope_scaling_factorandseq_len_interpolation_factor.seq_len_interpolation_factor.This fix allows RoPE scaling and position embedding interpolation to work as expected when configured via command-line arguments.
Contribution process
Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.